search

piotrmurach / tty-prompt

A beautiful and powerful interactive command line prompt
https://ttytoolkit.org
MIT License
1.47k stars 136 forks source link

Hide underlying `Choices#choices` from public API #147

Closed DanielVartanov closed 4 years ago

DanielVartanov commented 4 years ago

Describe the change

Hides the guts of Choices from the public API

Why are we doing this?

See https://github.com/piotrmurach/tty-prompt/pull/143/files#r443210835

Benefits

Underlying guts will be encapsulated from the public

Drawbacks

Requirements

Put an X between brackets on each line if you have done the item: [X] Tests written & passing locally? [X] Code style checked? [X] Rebased with master branch? [X] Documentation updated?

coveralls commented 4 years ago

Coverage Status

Coverage increased (+0.001%) to 97.36% when pulling 612eaf6adcef2378548eef65f9ee773b5e87cb22 on DanielVartanov:hide-raw-choices into 3bbe929b788b15eba0dd12596d7a85755b7dea9f on piotrmurach:master.

piotrmurach commented 4 years ago

Thank you! ❤️