piotrmurach / tty-prompt

A beautiful and powerful interactive command line prompt
https://ttytoolkit.org
MIT License
1.47k stars 136 forks source link

The markers for select and multi_select are broken #78

Closed DannyBen closed 5 years ago

DannyBen commented 6 years ago

Hi,

On my system, the markers for select and multi_select are broken: image

My system:

$ lsb_release -a
Distributor ID: Ubuntu
Description:    Ubuntu 16.04.3 LTS
Release:        16.04
Codename:       xenial

$ ruby -v
ruby 2.5.0p0 (2017-12-25 revision 61468) [x86_64-linux]

I noticed I am able to override the marker with both list and multi_list, but I also noticed that the radio markers are hardcoded.

Finally - I ran a test to see all the symbols in your Symbols module, to see what is broken in my system, this is the result, in case it helps.

image

Happy to provide any additional info, or test any fix candidate.

piotrmurach commented 6 years ago

To be fair I'm really surprised about the behaviour of your system. It feels like you're missing some serious unicode support :smile: There is no guarantee if we were to replace these with any other symbols they would work fine for everyone. I would be more inclined to create a theme option which allows to provide your own set of symbols that take precedence and allow to customise stuff in one place for all the prompts?

DannyBen commented 6 years ago

Yeah... I spent some time trying to find what is the unicode secret sauce that my system is missing, with no luck.

The ability to override the symbols array would be a great workaround.

piotrmurach commented 5 years ago

This is now fully configurable via :symbols option either at prompt initialization or individually per each input type.