search

piotrmurach / tty-spinner

A terminal spinner for tasks that have non-deterministic time frame.
https://ttytoolkit.org
MIT License
427 stars 28 forks source link

Multi spinner can register a spinner instance #32

Closed shanecav84 closed 5 years ago

shanecav84 commented 5 years ago

Describe the change

Modifies the MultiSpinner#register to accept a instance of TTY::Spinner.

Why are we doing this?

I have existing spinners that sometimes run by themselves, but that I would like to register with MultiSpinner under a specific condition.

Benefits

More flexibility.

Drawbacks

Unknown

Requirements

Put an X between brackets on each line if you have done the item: [x] Tests written & passing locally? [x] Code style checked? [x] Rebased with master branch? [x] Documentaion updated?

piotrmurach commented 5 years ago

Thanks for this quality PR! I will release shortly!

shanecav84 commented 5 years ago

Thanks for the quick turn-around!