search

piotrmurach / tty-spinner

A terminal spinner for tasks that have non-deterministic time frame.
https://ttytoolkit.org
MIT License
427 stars 28 forks source link

Bugfix: Restore hidden cursor #7

Closed m-o-e closed 8 years ago

m-o-e commented 8 years ago

Previously it would not be restored when stopping the spinner via #success or #error.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 95.726% when pulling eb17be42cae147f4d6d9fd42ff0e60c442843e1a on m-o-e:bugfix/restore-hidden-cursor into 6218ac1225c1ef46de91cf5c8c0384b93304f9ba on piotrmurach:master.

piotrmurach commented 8 years ago

That's a damn good PR! Thanks :heart:

m-o-e commented 8 years ago

Np, you're welcome. :)

It's a pleasure to work with such a clean codebase. Keep up the good work, much appreciated! 👍

piotrmurach commented 8 years ago

Cheers. There is whole suite of tty-* tools that may appeal to you, really keen to get feedback/help, if you have time that is please join the gitter chat room to discuss stuff in the future.

m-o-e commented 8 years ago

Thanks. Yes, I'm already using tty-prompt and tty-table. Will file issues/PRs if I run into problems.

I'll check gitter when I have some more time :)

piotrmurach commented 8 years ago

Sweet, you're a serious customer then :smile:

Gitter is pretty well integrated with GitHub, you can easily enter tty room anytime.