Swapped git ls-files dependency to ruby kernel DIR to avoid git error…

piotrmurach / tty

Toolkit for developing sleek command line apps.

https://ttytoolkit.org

MIT License

2.5k stars 78 forks source link

Swapped git ls-files dependency to ruby kernel DIR to avoid git error… #45

Closed quirinux closed 6 years ago

quirinux commented 6 years ago

Swapped the git dependencies on tty.gemspec file to avoid the issue https://github.com/piotrmurach/tty/issues/44

quirinux commented 6 years ago

it seems to be failing on windows tests, not sure if Dir["/*"] works on non-unix environments, but I thought it'd work

quirinux commented 6 years ago

even though had got an error on window CI test and changed Dir to Dir.glob to add better windows support those error are really related to other things than my changes

piotrmurach commented 6 years ago

I concluded that this is a really good idea to swap git exec to direct file listing. Thanks! ❤️