search

piotrulos / MSCModLoader

ModLoader for My Summer Car
GNU General Public License v3.0
113 stars 57 forks source link

Update to newer .Net Runtime & Fix on Mono w/out Wine #113

Closed Krutonium closed 4 years ago

Krutonium commented 4 years ago

It stopped working on Wine for me out of nowhere, so I ran it directly in Mono, and experienced numerous issues, mostly to do with the slashes being the wrong direction, which doesn't matter on Windows, but does matter on Linux and MacOS. I corrected that, then ran into an issue with Ionic.zip, which prompted me to remove it, upgrade the .Net version to 4.5, and use the built in .zip file handling, which is cleaner imho.

yasink21 commented 4 years ago

hey there, I am having trouble running this on Wine as well, could you provide me with the patched version of yours?

Thanks

piotrulos commented 4 years ago

4.5 will break compatibility with older OS versions, can't accept that change.

Krutonium commented 4 years ago

Which OS's are you looking to maintain compatibility with?

piotrulos commented 4 years ago

.net 4.0 is max, because suprisingly or not there are XP and vista users for mscloader.

piotrulos commented 4 years ago

also seen windows 2003 in stats.

Krutonium commented 4 years ago

Wine reports XP by default a lot of the time, are you sure it's not that? Regardless, I'll have to think of an alternative then - The zip library you're using seems to be broken on Mono.

Of note, You can't run Steam on Windows XP any more, so the likelyhood of someone who is playing on XP also being a pirate pretty damn high. As for Vista, .Net 4.5 works fine.

MSCPatcherLinux.zip @yasink21 Replace the normal exe with this and run with Mono

piotrulos commented 4 years ago

OS is reported by unity, and since you can just run native binary for linux it reports itself as linux not wine. So yeah there are few hundred legit players below win7.

Krutonium commented 4 years ago

Except that nobody really uses the Native Binary because it works better in wine anyway. The native executable has broken transparency.

piotrulos commented 4 years ago

I can just implement slashes changes from this PR, because it doesn't matter in windows, but will not change the runtime version. Besides old OS compatibility 4.0 is also default for most OS, you need to manually update to 4.5 in anything below win8.1. People still fails to follow simple instructions to unpack before running installation, I don't expect them to follow instructions to install 4.5.