Fix outdated link in Goals-section in README (#219)

piotrwitek / react-redux-typescript-guide

The complete guide to static typing in "React & Redux" apps using TypeScript

https://piotrwitek.github.io/react-redux-typescript-guide/

MIT License

13.35k stars 1.09k forks source link

Fix outdated link in Goals-section in README (#219) #220

Closed schrer closed 2 years ago

schrer commented 2 years ago

Description

Changed the outdated link in the Goals paragraph inside the README to point to #react-redux-typescript-ecosystem

Related issues:

Resolved #219

Checklist

[x] I have read CONTRIBUTING.md
[X] I have edited README_SOURCE.md (NOT README.md)
[X] I have run CI script locally npm run ci-check to generate an updated README.md
[X] I have linked all related issues above
[X] I have rebased my branch

schrer commented 2 years ago

I am not familiar with Semaphore CI, but I can't seem to find any details on why exactly the build failed.

All I can say is, that locally running npm run ci-check worked as intended, as long as I was using a node version below 13 on my Fedora 35 laptop (I used Node 12 LTS in the end). Versions after 13 did not seem to be able to run the script generate-readme.js because of an issue, with fs.writeFileSync. Could that be the issue here? Not sure how the Semaphore build is defined.

piotrwitek commented 2 years ago

Hey @schrer, there was a problem with CI because of the newer node version as you said thanks for that :) I have updated the script to run on newer node runtimes so should be working now, could you please rebase?

schrer commented 2 years ago

Done. Thanks for checking the build, and happy to help out :)