search

piotrwitek / react-redux-typescript-jspm-starter

Futuristic, bundle-free, development environment for building Component-Driven SPA with React, Redux and TypeScript - powered by JSPM (SystemJS & Rollup with tree-shaking)
https://piotrwitek.github.io/react-redux-typescript-jspm-starter/
MIT License
231 stars 43 forks source link

Add tsc task and fix most compile errors #16

Closed jonaskello closed 7 years ago

jonaskello commented 7 years ago

Fixes most problems in #15

jonaskello commented 7 years ago

Agreed on skipLibCheck. I set it to false. I also did some more changes in tsconfig and now all compile errors but one is fixed. Specifically I had to change noResolve to false and module to commonjs. I did this by trial and error so not sure why.

The remaining error is this:

src/containers/currency-converter-container/components/currency-valuation-header                            -calendar.tsx(2,22): error TS2307: Cannot find module 'react-input-calendar'.

I think it might be because there are no types installed for react-input-calendar?

piotrwitek commented 7 years ago

noResolve makes sense, because it strip out /// references to definition which are used in @types :) IMO module should be system, because it will validate all various import types not only require types for react-input-calendar should not be used, because the file actually importing that is not used by main app module, should check and fix includes in tsconfig

jonaskello commented 7 years ago

I think the requested changes are in now :-)

piotrwitek commented 7 years ago

@jonaskello merged, please check updated readme