search

piotrwitek / react-redux-typescript-jspm-starter

Futuristic, bundle-free, development environment for building Component-Driven SPA with React, Redux and TypeScript - powered by JSPM (SystemJS & Rollup with tree-shaking)
https://piotrwitek.github.io/react-redux-typescript-jspm-starter/
MIT License
231 stars 43 forks source link

Build task should generate a index.html in dist/ #20

Closed guillaume86 closed 7 years ago

guillaume86 commented 7 years ago

I tried to make it work by copying the base index.html and adapting the scripts urls to the ones in /dist/ but app.js failed to load.

Could you generate the proper html (maybe by "patching" the root index.html?) in addition to the js files?

Unrelated: Thanks for this repo, that starter kit looks really interesting to me, the dev performance aspect in particular.

guillaume86 commented 7 years ago

You can ignore this, I missed the assets folder... sorry

piotrwitek commented 7 years ago

Hi @guillaume86 , Cool, no problem but it means that I should update documentation on this, thx for your input.

I could add it to the queue, but right now I have a list of more important features to add. Contributions are welcome :)

guillaume86 commented 7 years ago

I'll have to evaluate different frameworks (React/Redux vs Angular2) for my job in a week or two. I'll probably use your starter kit as a base for the react prototype, I'll contribute if I manage to do useful and clean additions.

I'm not experienced with the React/Redux/TS combo so I'm not sure I'll be very helpful, but your code is very informative so thanks.

piotrwitek commented 7 years ago

Any kind of feedback is valuable for me to improve :) Thanks and good luck in finding the best solution for your project.

Pozdrawiam, Piotr Witek

2016-10-06 14:42 GMT+02:00 Guillaume Lecomte notifications@github.com:

I'll have to evaluate different frameworks (React/Redux vs Angular2) for my job in a week or two. I'll probably use your starter kit as a base for the react prototype, I'll contribute if I manage to do useful and clean additions.

I'm not experienced with the React/Redux/TS combo so I'm not sure I'll be very helpful, but your code is very informative so thanks.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/piotrwitek/react-redux-typescript-starter-kit/issues/20#issuecomment-251949981, or mute the thread https://github.com/notifications/unsubscribe-auth/AAtHA4t-Rh5ZP5Ie0d-uaR1BjYiGFHimks5qxOyjgaJpZM4KP24h .