search

piotrwitek / react-redux-typescript-jspm-starter

Futuristic, bundle-free, development environment for building Component-Driven SPA with React, Redux and TypeScript - powered by JSPM (SystemJS & Rollup with tree-shaking)
https://piotrwitek.github.io/react-redux-typescript-jspm-starter/
MIT License
231 stars 43 forks source link

strictNullChecks: true by default #25

Closed karudo closed 7 years ago

karudo commented 7 years ago

I think, if we use typescript 2, we should set strictNullChecks: true by default. What is your opinion?

piotrwitek commented 7 years ago

Yes I would definitely try to switch strictNullChecks because of the benefits it could bring to my code base, though currently I have other things on my plate, I will certainly add it in the future. Thanks for suggestion.

piotrwitek commented 7 years ago

I think I'll do it now with TS 2.1 release, with it's better support for type inference, non-nullable types (when strictNullChecks and noImplicitAny is enabled) will give a huge benefit of better type safety across entire codebase.

piotrwitek commented 7 years ago

@karudo done! 7cb59ab453d850ca7c7de822d5222597c0329fe5

piotrwitek commented 7 years ago

also greatly improved Store, Reducers, Actions and Props types across the board