piotrwitek / react-redux-typescript-jspm-starter

Futuristic, bundle-free, development environment for building Component-Driven SPA with React, Redux and TypeScript - powered by JSPM (SystemJS & Rollup with tree-shaking)
https://piotrwitek.github.io/react-redux-typescript-jspm-starter/
MIT License
231 stars 43 forks source link

cross-platform npm scripts #26

Closed maxali closed 7 years ago

maxali commented 7 years ago

There are some npm scripts that are using Linux special commands like: cp command in init:dist, regenerator and post_jspm-bundle-vendor-prod.

This will not work in Windows environment. I had to use Cygwin tool to use linux commands.

We may create nodejs build file (build.js) which would make use of fs, and call it from npm scripts like node ./build --some arguments.

Do you have any idea how we can make it cross-platform.

piotrwitek commented 7 years ago

@maxali I can look into that in the future, but I'm not using windows so I'll not be able to test it. If you'd like you can try to create this build script yourself, please submit PR then I'll review it and add it to the project.

maxali commented 7 years ago

Submitted PR #27 to solve this.

piotrwitek commented 7 years ago

@maxali I have investigated this suggestion and decided I'll rather use https://www.npmjs.com/package/shelljs project instead of proposed ncp. Other concerns:

piotrwitek commented 7 years ago

I'll rewrite commands entirely as node scripts, to clean up cluttered package.json.

piotrwitek commented 7 years ago

@maxali Done: https://github.com/piotrwitek/react-redux-typescript-starter-kit/pull/28