async actions type refactoring

piotrwitek / typesafe-actions

Typesafe utilities for "action-creators" in Redux / Flux Architecture

https://codesandbox.io/s/github/piotrwitek/typesafe-actions/tree/master/codesandbox

MIT License

2.41k stars 98 forks source link

async actions type refactoring #182

Closed maximelkin closed 5 years ago

maximelkin commented 5 years ago

Description

Related issues:

Resolved #153

Checklist

[x] I have read CONTRIBUTING.md
[x] I have linked all related issues above
[x] I have rebased my branch

For bugfixes:

[ ] I have added at least one unit test to confirm the bug have been fixed
[ ] I have checked and updated TOC and API Docs when necessary

For new features:

[ ] I have added entry in TOC and API Docs
[ ] I have added a short example in API Docs to demonstrate new usage
[ ] I have added type unit tests with dts-jest
[ ] I have added runtime unit tests with dts-jest

piotrwitek commented 5 years ago

Hey, thanks for your help although there are some issues with your PR.

https://github.com/piotrwitek/typesafe-actions/blob/master/CONTRIBUTING.md point #2 is violated

Also there is no description or explanation

maximelkin commented 5 years ago

Ok, sorry for violations and thanks for feedback

piotrwitek commented 5 years ago

@maximelkin that's alright, thanks for trying to help, although for now, I would strongly suggest to not work on this feature as there is a significant amount of changes in the next branch (currently heavily WIP) that is not compatible with your PR, I suggest to wait with any work until it's unblocked.