piotrwitek / typesafe-actions

Typesafe utilities for "action-creators" in Redux / Flux Architecture
https://codesandbox.io/s/github/piotrwitek/typesafe-actions/tree/master/codesandbox
MIT License
2.41k stars 98 forks source link

Update internal type correctness unit-test framework to dts-jest #77

Closed piotrwitek closed 5 years ago

piotrwitek commented 6 years ago

Historically typesafe-actions was created well before there was any solutions in the wild that would allow to unit-test correctness of resulting type annotations. So I had to improvise and cook my own solution to do that, unfortunately this increased a cost of maintenance and adding new features slowing down development and increasing effort.

~I want to fix that now and leverage a really nice solution created by the TypeScript team: https://github.com/Microsoft/dtslint~

UPDATE: After initial evaluation and implementation of dtslint it proved it's not a good solution for a library because it was designed for ambient types testing for definitely-typed project. After that I spend some time investigating other options and it turned out npm-ramda project uses another library dts-jest which is exactly what I was looking for.

This task is updated to use dts-jest for type testing.

This will allow to add new features with less effort and also increase the type correctness unit-test coverage.

Planned work:

IssueHuntBot commented 6 years ago

@loadbalance-sudachi-kun funded this issue with $256. Visit this issue on Issuehunt

IssueHuntBot commented 6 years ago

@piotrwitek has started working. Visit this issue on Issuehunt

IssueHuntBot commented 5 years ago

@piotrwitek has submitted a pull request. See it on IssueHunt

IssueHuntBot commented 5 years ago

@piotrwitek has rewarded $179.20 to @piotrwitek. See it on IssueHunt