pioz / tvdb2

Ruby wrapper for TVDB api version 2
MIT License
4 stars 0 forks source link

remove URI.escape calls in client #3

Closed klausmeyer closed 3 years ago

klausmeyer commented 3 years ago

Hi,

I recently updated my application using this library to Ruby 2.7 and just noticed that it started printing the following message in the logs:

lib/tvdb2/client.rb:108: warning: URI.escape is obsolete

I tried changing it to CGI.escape or URI.encode_www_form_component as suggested in the docs but this would also encode the leading slash of the path component. After checking the API docs of TheTVDB I'm almost sure there shouldn't be a need to escape the paths anyways as they only contain URL safe chars.

pioz commented 3 years ago

Ty for your support.