pipacs / o2

OAuth 2.0 for Qt
BSD 2-Clause "Simplified" License
317 stars 147 forks source link

o2.cpp : patch from digiKam core about scope and state parameters #158

Open cgilles opened 2 years ago

cgilles commented 2 years ago

Hi,

In digiKam core we host the O2 source code internally to communicate with remote web service and export items from photo collections.

Few days ago, digiKam have been ported to Qt6 (it still compatible with Qt5) and i updated as well O2 library with last code available (previous version dating a lots)

Recently, a student working on ImgUr plugin for digiKam, has restored a small patch that i forget to re-integrate to O2:

https://invent.kde.org/graphics/digikam/-/merge_requests/170/diffs#842297e068b45b02767c92fbe54bbceec08c8ae8

Typically, in some conditions (probably an older Qt5 version), this patch must be applied to communicate properly.

We will re-integrate this patch to the O2 source code from digiKam core.

Best regards

Gilles Caulier

cgilles commented 2 years ago

Student account in github: @quochungtran2000

cgilles commented 2 years ago

Details from the student to reproduce the problem:

https://invent.kde.org/graphics/digikam/-/merge_requests/170#note_410059

Code from the ImgUr plugin using O2 library:

https://invent.kde.org/graphics/digikam/-/blob/master/core/dplugins/generic/webservices/imgur/imgurtalker.cpp