search

pipacs / o2

OAuth 2.0 for Qt
BSD 2-Clause "Simplified" License
317 stars 147 forks source link

Error reading, custom html page on success and SurveyMonkey support #40

Closed jimmytaker closed 8 years ago

pipacs commented 8 years ago

Thanks, looking great! One small nit: If we re-serve the content from the reply after success, we should re-serve it with the corresponding content type. Could you please extend your change with this.

jimmytaker commented 8 years ago

Hey,

I am sorry, I do not understand what you mean by this... Expose the setting of the content-type in the same way I exposed the content (as a property) or maybe change it so that instead of only the content the whole reply can be customized? Or I completely misunderstood what you are talking about?

Cheers,

JT

Von: Akos Polster [mailto:notifications@github.com] Gesendet: Dienstag, 5. Januar 2016 12:49 An: pipacs/o2 Cc: jimmytaker Betreff: Re: [o2] Error reading, custom html page on success and SurveyMonkey support (#40)

Thanks, looking great! One small nit: If we re-serve the content from the reply after success, we should re-serve it with the corresponding content type. Could you please extend your change with this. — Reply to this email directly or view it on GitHub.

pipacs commented 8 years ago

Yes, that’s it. You save the received content but not the content-type, which is now hard-coded to text/html.

~ Akos.

On 05 Jan 2016, at 13:35, jimmytaker notifications@github.com wrote:

Hey,

I am sorry, I do not understand what you mean by this... Expose the setting of the content-type in the same way I exposed the content (as a property) or maybe change it so that instead of only the content the whole reply can be customized? Or I completely misunderstood what you are talking about?

Cheers,

JT

Von: Akos Polster [mailto:notifications@github.com] Gesendet: Dienstag, 5. Januar 2016 12:49 An: pipacs/o2 Cc: jimmytaker Betreff: Re: [o2] Error reading, custom html page on success and SurveyMonkey support (#40)

Thanks, looking great! One small nit: If we re-serve the content from the reply after success, we should re-serve it with the corresponding content type. Could you please extend your change with this. — Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHub https://github.com/pipacs/o2/pull/40#issuecomment-168988338.