Tidy up TimedReply for OAuth1.

pipacs / o2

OAuth 2.0 for Qt

BSD 2-Clause "Simplified" License

317 stars 147 forks source link

Tidy up TimedReply for OAuth1. #46

Closed dbrnz closed 8 years ago

dbrnz commented 8 years ago

I wanted to remove #include "o1requestor.moc" from o1requestor.cpp and also:

connect(this, SIGNAL(error(QNetworkReply::NetworkError)), parent, SIGNAL(error(QNetworkReply::NetworkError)));

looked dubious -- hopefully this is an improvement.

pipacs commented 8 years ago

Thanks, but TimedReply is an internal class, I see no reason to publish it. Forwarding the error signal is important as well.

dbrnz commented 8 years ago

OK, I'm happy with the code (I hadn't looked close enough before...). However, when using it as part of a larger project and building with CMake, the #include "o1requestor.moc" stops the build as the file cannot be found -- with TimedReply in o1requestor.h (and renamed) all is well.

Would you accept a PR putting TimedReply into the header file??

Thanks.

pipacs commented 8 years ago

Sure, if this helps CMake, let's do it. Two things though:

Have you tried with AUTOMOC? https://cmake.org/cmake/help/v3.0/prop_tgt/AUTOMOC.html
If that doesn't help, could you publish it as O1TimedReply in O1TimedReply.h|cpp

dbrnz commented 8 years ago

I'm back onto this after other commitments...

AUTOMOC doesn't help so have created o1timedreply.h and .cpp.