search

pipacs / o2

OAuth 2.0 for Qt
BSD 2-Clause "Simplified" License
317 stars 147 forks source link

Silent failure on windows #75

Closed darakian closed 7 years ago

darakian commented 7 years ago

Hey all, just spent the day tracking down a bug when using o2 on windows. If QCoreApplication::setOrganizationName(); QCoreApplication::setApplicationName(); Are not set then the Qsettings used in o2 will fail to write key value pairs (but will continue to run!). The return values end up being empty strings which causes everything to fail and when porting an application this can be quite annoying.

I'm mostly sharing so that others that hit this issue can find a quick fix, but it might be worth having o2 check if these are set and to set some defaults if not.

ikushn-s commented 7 years ago

I've also spent a day because of this bug. SmugMug authorization worked on Linux and Mac, but not on Windows. For me setting organization name alone suffices to fix the issue. I think that the organization name should be set in the examples.

pipacs commented 7 years ago

Fixed by a77d5073074ecb4294a86f870cf971d465354161