search

pipacs / o2

OAuth 2.0 for Qt
BSD 2-Clause "Simplified" License
317 stars 147 forks source link

added keychain store #77

Closed pollend closed 7 years ago

pollend commented 7 years ago

This pull request implements qtkeychain. I think this would generally be preferable over encryption through obfuscation. You will have to test this on your end to make sure this works. I will probably test if this works on my own end but I would like to make this available for review.

https://github.com/frankosterfeld/qtkeychain

  • Mac OS X: Passwords are stored in the OS X Keychain.

  • Linux/Unix: If running, GNOME Keyring is used, otherwise qtkeychain tries to use KWallet (via D-Bus), if available.

  • Windows: By default, the Windows Credential Store is used (requires Windows 7 or newer). Pass -DUSE_CREDENTIAL_STORE=OFF to cmake use disable it. If disabled, QtKeychain uses the Windows API function CryptProtectData to encrypt the password with the user's logon credentials. The encrypted data is then persisted via QSettings.

pipacs commented 7 years ago

Thanks! I guess the project file needs to be updated as well. Plus there is a merge conflict now due to the previous change.

pollend commented 7 years ago

sure, I'll update the documentation and merge from the master.

pipacs commented 7 years ago

Thanks! I meant the project file (.pri), not the readme. But that update is welcome as well.