Forward replyServer_'s reply content getter/setter in O1

pipacs / o2

OAuth 2.0 for Qt

BSD 2-Clause "Simplified" License

317 stars 147 forks source link

Forward replyServer_'s reply content getter/setter in O1 #96

Closed stpetruk closed 6 years ago

stpetruk commented 7 years ago

Hello @pipacs, I've got a suggestion and don't know if it is suitable for the existing class design. Maybe you or I can pull replyServer_ from O1 and O2 up into O0BaseAuth?

pipacs commented 6 years ago

Hi @strepuk, what are you trying to achieve, what would be the use case?

stpetruk commented 6 years ago

Hi @pipacs, I need to show up a custom html page after successful login using the O1 Authorization. I cannot use embedded browser because I've got a platform dependent bugs with WebEngine and WebKit, so the only solution is to use external browser. If you asked about pulling replyServer_ from O1 and O2 into O0BaseAuth then it'll reduce code duplication in O1 and O2 because I've just copied the existing code from O2 into O1.

pipacs commented 6 years ago

Sorry for the delay, and yeah, moving replyServer to O0BaseAuth would the the best approach.