search

pipauwel / IFCtoRDF

IFCtoRDF is a set of reusable Java components that allows to parse IFC-SPF files and convert them into RDF graphs.
Other
83 stars 31 forks source link

Tests fail #28

Closed fkleedorfer closed 1 year ago

fkleedorfer commented 3 years ago

To reprocduce:

  1. clone the repository
  2. run mvn install
fkleedorfer commented 3 years ago

The problem seems to be that the ontology URI has changed, but the tests have not been updated.

This is the output generated by the tests with #29 

org.opentest4j.AssertionFailedError: Actual output differs from expected output:
  input: file C:\DATA\DEV\workspace\IFCtoRDF\target\test-classes\convertIFCFileToOutputTTL\PiPauwel_IFCtoRDF_test10.ttl
  expected output file: target\PiPauwel_IFCtoRDF_test10.ttl
  difference at line 2
  expected line:# imports: http://standards.buildingsmart.org/IFC/DEV/IFC4/ADD1/OWL
    actual line:# imports: http://standards.buildingsmart.org/IFC/DEV/IFC4/ADD2_TC1/OWL
fkleedorfer commented 3 years ago

I tentatively replaced the occurrences of http://standards.buildingsmart.org/IFC/DEV/IFC4/ADD1/OWL in the /src/test/resources/convertIFCFileToOutputTTL/.+.ttl files to http://standards.buildingsmart.org/IFC/DEV/IFC4/ADD2_TC1/OWL.

Next problem as per #29:

org.opentest4j.AssertionFailedError: Actual output differs from expected output:
  input: file C:\DATA\DEV\workspace\IFCtoRDF\target\test-classes\convertIFCFileToOutputTTL\PiPauwel_IFCtoRDF_test13.ttl
  expected output file: target\PiPauwel_IFCtoRDF_test13.ttl
  difference at line 4
  expected line:@prefix ifc:  <http://standards.buildingsmart.org/IFC/DEV/IFC4/ADD2_TC1/OWL#> .
    actual line:@base          <http://linkedbuildingdata.net/ifc/resources/> .

so, it seems that more about the ttl structure has changed. I don't think that the line-by line comparison of the models is the right way to go about this. It would be better to obtain a jena Model (or Dataset, if necessary) as the conversion result and from the expected file, and check if the models are isomorphic. I'll provide another PR that does that.

pipauwel commented 1 year ago

Thanks for the issue and request. As the project is archived and no longer maintained, however, I can't implement this change any more.