search

pipe-cd / pipecd

The One CD for All {applications, platforms, operations}
https://pipecd.dev
Apache License 2.0
1.08k stars 152 forks source link

Add helm lint to CI #4588

Open kentakozuka opened 1 year ago

kentakozuka commented 1 year ago

What would you like to be added:

Why is this needed:

hungran commented 1 year ago

https://github.com/pipe-cd/pipecd/pull/4587#issuecomment-1704543465 I've mentioned from this issue better if we can have chart testing lint and install

also we can think about KIND Cluster to apply the template by default values and more case if we need to make sure our template is working

hungran commented 1 year ago

https://github.com/helm/chart-testing/pull/445 since chart-testing not yet support pulling chart from OCI yet we might need to wait this :) from my opinion, does apply to KIND Cluster during the CI is good enough @kentakozuka @khanhtc1202 wdyt?

kentakozuka commented 1 year ago

@hungran Correct me if I was wrong, but none of the charts under /manifests references osc://. So, I am not sure if we have to wait for the PR merged that you address.

hungran commented 1 year ago

@kentakozuka sorry for the late response, what I mean is chart testing we can do more than lint we can also try to pull the chart (by chart testing) to make sure it can be pull

kentakozuka commented 1 year ago

@hungran sounds cool!