search

pipe-cd / pipecd

The One CD for All {applications, platforms, operations}
https://pipecd.dev
Apache License 2.0
1.09k stars 153 forks source link

Exit with error status code when plan preview failed #4660

Closed TakumaKurosawa closed 6 months ago

TakumaKurosawa commented 1 year ago

What would you like to be added: Call os.Exit(1) when plan-preview sent an error message.

Why is this needed: Plan preview CI send error comment but workflow is still succeeded. So we have to exit with error status code when exception case.

TakumaKurosawa commented 1 year ago

I'd like to work on this. I've already make PR: https://github.com/pipe-cd/pipecd/pull/4659

github-actions[bot] commented 6 months ago

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

t-kikuc commented 6 months ago

This is already solved. https://github.com/pipe-cd/pipecd/blob/972d114cfc47a4465b69e4307136b083fe9d5388/tool/actions-plan-preview/main.go#L152