pipe-cd / pipecd

The One CD for All {applications, platforms, operations}
https://pipecd.dev
Apache License 2.0
1.1k stars 154 forks source link

[ECS]When using application autoscaling, the desired count must be adjusted each time. #5027

Closed tom-256 closed 4 months ago

tom-256 commented 5 months ago

What would you like to be added: When using Application AutoScaling in ECS, ignore desiredCount parameter.

Why is this needed:

For example, Terraform allows you to ignore settings https://github.com/terraform-aws-modules/terraform-aws-ecs/blob/master/docs/README.md#service-1

t-kikuc commented 4 months ago

I created a draft PR https://github.com/pipe-cd/pipecd/pull/5030 to solve it. After testing, I'll make it ready for review.

That will enable you to ignore desiredCount on updating a service by a new config attribute ignoreDesiredCountOnUpdate.

Of course, desiredCount will be ignored while ECS's DriftDetection(In Progress feature yet).

Another way I did not choose

Another way is to make it possible to configure autoscaling in PipeCD. (e.g. by introducing a new definition file)

It is tougher to develop because:

If required, we can discuss how to manage autoscaling in PipeCD here: https://github.com/pipe-cd/pipecd/discussions/4709.