pipe-cd / pipecd

The One CD for All {applications, platforms, operations}
https://pipecd.dev
Apache License 2.0
1.09k stars 153 forks source link

Discard the otel logs #5146

Closed Warashi closed 2 months ago

Warashi commented 3 months ago

What this PR does / why we need it:

If the control plane disables the monitoring feature, piped's OTEL TracerProvider logs some errors because the otel collector does not exist. It's not a problem, but we don't want to see error logs. So we discard the otel logs.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 22.79%. Comparing base (71b46e0) to head (89cd6e8). Report is 11 commits behind head on master.

Files Patch % Lines
pkg/app/piped/cmd/piped/piped.go 0.00% 5 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #5146 +/- ## ======================================= Coverage 22.79% 22.79% ======================================= Files 412 412 Lines 43827 43832 +5 ======================================= + Hits 9989 9992 +3 - Misses 33050 33052 +2 Partials 788 788 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.