search

pipe-cd / pipecd

The One CD for All {applications, platforms, operations}
https://pipecd.dev
Apache License 2.0
1.09k stars 153 forks source link

[Lambda] Support Drift Detection for Lambda #5186

Closed t-kikuc closed 2 months ago

t-kikuc commented 2 months ago

What this PR does / why we need it:

Supported DriftDetection for Lambda

When OutOfSync: image

Restrictions:

Which issue(s) this PR fixes:

Fixes #5182

Does this PR introduce a user-facing change?: Users can see drifts.

Note:

To use this feature, users need to add the following IAM Actions to their Piped's IAM Role.

Later I'll describe the details in another PR.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 5.97610% with 236 lines in your changes missing coverage. Please review.

Project coverage is 22.85%. Comparing base (adf2c51) to head (be00911). Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
pkg/app/piped/driftdetector/lambda/detector.go 6.38% 220 Missing :warning:
pkg/app/piped/driftdetector/detector.go 0.00% 16 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #5186 +/- ## ========================================== - Coverage 22.93% 22.85% -0.09% ========================================== Files 419 420 +1 Lines 44986 45247 +261 ========================================== + Hits 10318 10340 +22 - Misses 33873 34111 +238 - Partials 795 796 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

t-kikuc commented 2 months ago

@ffjlabo Would you please review again?

This is the only one change: https://github.com/pipe-cd/pipecd/pull/5186#discussion_r1745009233

ffjlabo commented 2 months ago

Sorry for the rough review🙏 I rechecked the new fix. It is fine.