pipe-cd / pipecd

The One CD for All {applications, platforms, operations}
https://pipecd.dev
Apache License 2.0
1.09k stars 153 forks source link

Fix the default values of pipecd manifest #5188

Closed Warashi closed 2 months ago

Warashi commented 2 months ago

What this PR does / why we need it:

Fix the default values to correct the OpenTelemetry Collector's exporter and the Grafana Tempo's remote_write target URL. Without this PR, the control plane whose release name is not 'pipecd' cannot handle the OpenTelemetry Traces.

Which issue(s) this PR fixes:

Fixes #4977

Does this PR introduce a user-facing change?:

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 22.93%. Comparing base (a12ab46) to head (fb0b866). Report is 5 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #5188 +/- ## ======================================= Coverage 22.93% 22.93% ======================================= Files 419 419 Lines 44986 44986 ======================================= + Hits 10316 10318 +2 + Misses 33876 33873 -3 - Partials 794 795 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.