pipe-cd / pipecd

The One CD for All {applications, platforms, operations}
https://pipecd.dev
Apache License 2.0
1.09k stars 153 forks source link

Discard otel errors #5193

Closed Warashi closed 2 months ago

Warashi commented 2 months ago

What this PR does / why we need it:

This PR discards all errors and logs from the otel library. Without this PR, we will see error logs when an error occurs, like the one below.

2024/09/06 13:16:53 traces export: rpc error: code = PermissionDenied desc =

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 22.84%. Comparing base (e7c40a0) to head (90bc82c). Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/app/piped/cmd/piped/piped.go 0.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #5193 +/- ## ========================================== - Coverage 22.86% 22.84% -0.02% ========================================== Files 420 420 Lines 45247 45245 -2 ========================================== - Hits 10344 10338 -6 - Misses 34108 34112 +4 Partials 795 795 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.