pipe-cd / pipecd

The One CD for All {applications, platforms, operations}
https://pipecd.dev
Apache License 2.0
1.09k stars 153 forks source link

Revert "Enable the persistence of the Grafana Tempo" #5209

Closed Warashi closed 2 months ago

Warashi commented 2 months ago

Reverts pipe-cd/pipecd#5208

After merging the above PR, Grafana Tempo's pod becomes CrashLoopBackOff in the dev environment. The logs say there is a permission issue of persistent volume.

{"caller":"main.go:121","err":"failed to init module services: error initialising module: store: failed to create store: mkdir /var/tempo/traces: permission denied","level":"error","msg":"error running Tempo","ts":"2024-09-12T09:24:39.054661796Z"}                                                                                                                    

I think we have encountered this issue. https://github.com/grafana/helm-charts/issues/3197

Warashi commented 2 months ago

I could not reproduce this issue with my local kind cluster so that it may depend on the storage backend. This means it's challenging to prepare a generic workaround, I think. I want to revert those changes and use container-local storage as a default option.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 22.83%. Comparing base (41ae6d1) to head (3fee9f2). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #5209 +/- ## ======================================= Coverage 22.83% 22.83% ======================================= Files 420 420 Lines 45302 45302 ======================================= Hits 10344 10344 Misses 34163 34163 Partials 795 795 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.