Closed Warashi closed 5 days ago
Attention: Patch coverage is 0%
with 18 lines
in your changes missing coverage. Please review.
Project coverage is 22.81%. Comparing base (
5b9d417
) to head (efa4e6d
). Report is 4 commits behind head on master.
Files with missing lines | Patch % | Lines |
---|---|---|
pkg/app/piped/controller/controller.go | 0.00% | 18 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
What this PR does / why we need it:
This PR modifies the planner/scheduler cleanup to be single-threaded in order to reduce the file IO loads. I did a load test with the following scenario and discovered that os.RemoveAll creates a high load for piped:
In this scenario, the piped requires about 20 minutes to complete all deployments. After this PR, the piped requires about 15 minutes to complete.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: Yes
How are users affected by this change:
Is this breaking change:
How to migrate (if breaking change):