pipe-cd / pipecd

The One CD for All {applications, platforms, operations}
https://pipecd.dev
Apache License 2.0
1.09k stars 153 forks source link

Add toolregistry client as DeploymentService member #5228

Closed Warashi closed 1 month ago

Warashi commented 1 month ago

What this PR does / why we need it:

as title

Which issue(s) this PR fixes:

Part of #4980

Does this PR introduce a user-facing change?: No

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 22.92%. Comparing base (c3386cf) to head (da5b80a). Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...kg/app/pipedv1/plugin/toolregistry/toolregistry.go 0.00% 10 Missing :warning:
...app/pipedv1/plugin/kubernetes/deployment/server.go 0.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #5228 +/- ## ======================================= Coverage 22.91% 22.92% ======================================= Files 419 420 +1 Lines 45321 45332 +11 ======================================= + Hits 10385 10391 +6 - Misses 34139 34144 +5 Partials 797 797 ``` | [Flag](https://app.codecov.io/gh/pipe-cd/pipecd/pull/5228/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pipe-cd) | Coverage Δ | | |---|---|---| | [](https://app.codecov.io/gh/pipe-cd/pipecd/pull/5228/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pipe-cd) | `22.92% <0.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pipe-cd#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.