pipe-cd / pipecd

The One CD for All {applications, platforms, operations}
https://pipecd.dev
Apache License 2.0
1.09k stars 153 forks source link

Add k8s plugin's toolregistry implementation #5243

Closed Warashi closed 1 month ago

Warashi commented 1 month ago

What this PR does / why we need it:

The plugin has to pass the tool install script to the piped. I don't want to pass a script everywhere the plugin tries to install a tool. So I wrote a wrapper package to hide install script from other implementations.

Which issue(s) this PR fixes:

Part of #4980

Does this PR introduce a user-facing change?: No

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 23.94%. Comparing base (c1a06aa) to head (bb55a18). Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...pipedv1/plugin/kubernetes/toolregistry/registry.go 0.00% 10 Missing :warning:
...kg/app/pipedv1/plugin/toolregistry/toolregistry.go 0.00% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #5243 +/- ## ========================================== - Coverage 23.95% 23.94% -0.01% ========================================== Files 437 438 +1 Lines 46997 47008 +11 ========================================== Hits 11258 11258 - Misses 34835 34846 +11 Partials 904 904 ``` | [Flag](https://app.codecov.io/gh/pipe-cd/pipecd/pull/5243/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pipe-cd) | Coverage Δ | | |---|---|---| | [](https://app.codecov.io/gh/pipe-cd/pipecd/pull/5243/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pipe-cd) | `23.94% <0.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pipe-cd#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.