Support disabling the LiveState feature

pipe-cd / pipecd

The One CD for All {applications, platforms, operations}

https://pipecd.dev

Apache License 2.0

1.09k stars 153 forks source link

Support disabling the LiveState feature #5270

Open t-kikuc opened 1 month ago

t-kikuc commented 1 month ago

What would you like to be added:

Support disabling the LiveState feature for a platform-provider.
- e.g. Add enableLiveState: true/false flag in PlatformProviderLambdaConfig.

Why is this needed:

For those who don't need DriftDetection and LiveState UI, the LiveState feature is not necessary.
LiveState feature calls a lot of APIs (e.g. AWS, GCP, etc.), but it would lead to higher cost.
- Especially, the number of API calls tends to be higher for function platforms like Lambda/CloudRun.

t-kikuc commented 1 month ago

💡 An idea of implementation is like this: https://github.com/pipe-cd/pipecd/commit/82988086a99232d6908a7d1ce245ffa7629750ac

khanhtc1202 commented 1 month ago

I think the configuration for features like livestate or drift detection to be on/off should belong to application configuration instead of piped platform provider or plugin config since users may use the same platform/plugin config of piped to manage various applications with different attentions, wdyt? 🤔

t-kikuc commented 1 month ago

Disabling LiveState&DriftDetection for each app does not have an effect on reducing API calls. Even if LiveState of only one app is enabled, livestatestore will fetch all resources.

ffjlabo commented 4 weeks ago

FYI, it seems that there was a similar issue with disabling drift detection: https://github.com/pipe-cd/pipecd/issues/4508. This is implemented as a temporary option for the terraform provider in the piped config. https://pipecd.dev/docs-v0.49.x/user-guide/managing-piped/configuration-reference/#platformproviderterraformconfig