Cannot navigate to the edit page even after clicking "Edit this page".

pipe-cd / pipecd

The One CD for All {applications, platforms, operations}

https://pipecd.dev

Apache License 2.0

1.09k stars 153 forks source link

Cannot navigate to the edit page even after clicking "Edit this page". #5287

Closed Reimei1213 closed 3 weeks ago

Reimei1213 commented 3 weeks ago

What happened: Clicking “Edit this page” in the upper right corner takes me to an unintended page.

Extra slash between en and docs-v0.49.x in url
Missing .md extension

スクリーンショット 2024-10-22 23 27 47

What you expected to happen:

I wanted to transition to this page.

How to reproduce it:

https://pipecd.dev/docs-v0.49.x/user-guide/metrics/

Environment:

piped version:
control-plane version:
Others:

ntheanh201 commented 3 weeks ago

IMO, this happened because of this commit: https://github.com/pipe-cd/pipecd/pull/5017 When I ran Hugo locally with version 0.92.1, this issue didn't happen. When I ran Hugo locally with version 0.128.0, this issue happened.

khanhtc1202 commented 3 weeks ago

@ntheanh201 @Reimei1213 Thanks for noticing us.

Could you also check the "Edit this page" link on this page? ref: https://pipecd.dev/docs-v0.49.x/quickstart/

Looks like if the docs markdown file is _index.md under the path name, it could jump correctly. So, for whatever fix, please ensure it also works with this kind of link.