Closed t-kikuc closed 2 weeks ago
Attention: Patch coverage is 86.95652%
with 3 lines
in your changes missing coverage. Please review.
Project coverage is 25.23%. Comparing base (
c842a89
) to head (48ea969
). Report is 8 commits behind head on master.
Files with missing lines | Patch % | Lines |
---|---|---|
pkg/app/piped/driftdetector/ecs/detector.go | 86.95% | 3 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
What this PR does:
NOTE: I'll fix Lambda too, it has the same problem.
Why we need it:
Without this PR, unexpected diff appears in ECS PlanPreview.
e.g.
Subnets
,Essential
, andProtocol
are unexpected.The cause is that
ignoreAndSortParameters()
in ECS DriftDetection unintentionally overwrites ECS manifests in AppManifestsCache.Which issue(s) this PR fixes:
Does this PR introduce a user-facing change?: