pipe-cd / pipecd

The One CD for All {applications, platforms, operations}
https://pipecd.dev
Apache License 2.0
1.09k stars 153 forks source link

[ECS] Fix unexpected diff of Plan Preview #5306

Closed t-kikuc closed 2 weeks ago

t-kikuc commented 2 weeks ago

What this PR does:

NOTE: I'll fix Lambda too, it has the same problem.

Why we need it:

Which issue(s) this PR fixes:

Does this PR introduce a user-facing change?:

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 86.95652% with 3 lines in your changes missing coverage. Please review.

Project coverage is 25.23%. Comparing base (c842a89) to head (48ea969). Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
pkg/app/piped/driftdetector/ecs/detector.go 86.95% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #5306 +/- ## ========================================== + Coverage 25.02% 25.23% +0.20% ========================================== Files 447 444 -3 Lines 47520 47480 -40 ========================================== + Hits 11892 11980 +88 + Misses 34690 34559 -131 - Partials 938 941 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.