search

pipe-cd / pipecd

The One CD for All {applications, platforms, operations}
https://pipecd.dev
Apache License 2.0
1.09k stars 153 forks source link

Implement checkImageChange and tests #5333

Closed Warashi closed 2 days ago

Warashi commented 3 days ago

What this PR does:

Implement checkImageChange and tests. The checkImageChange detects changed images from the difference of manifests.

Why we need it:

We must detect whether there are changed images or not to determine the sync strategy and its descriptions. If there are changed images in diffs, we choose the pipeline sync strategy. If there are no changed images in diffs, we determine the sync strategy with other viewpoints.

Which issue(s) this PR fixes:

Part of #4980

Does this PR introduce a user-facing change?: No

codecov[bot] commented 3 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 25.31%. Comparing base (1763f92) to head (1112cd9). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #5333 +/- ## ========================================== + Coverage 25.28% 25.31% +0.02% ========================================== Files 444 444 Lines 47574 47592 +18 ========================================== + Hits 12028 12046 +18 Misses 34603 34603 Partials 943 943 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

khanhtc1202 commented 2 days ago

LGTM with small nits 👍