search

pipe-cd / pipecd

The One CD for All {applications, platforms, operations}
https://pipecd.dev
Apache License 2.0
1.09k stars 153 forks source link

Sort trailers to ensure the order #5334

Closed ffjlabo closed 2 days ago

ffjlabo commented 2 days ago

What this PR does:

Sort trailers before commit with them to ensure the order.

Why we need it:

Which issue(s) this PR fixes:

Part of https://github.com/pipe-cd/pipecd/issues/5028

Does this PR introduce a user-facing change?:

khanhtc1202 commented 2 days ago

@ffjlabo Go build and test failed, maybe caused by the CI go version 👀

ffjlabo commented 2 days ago

@khanhtc1202 Sorry, it seems that these feature are supported from Go 1.23. So I will rewrite it with Go 1.22 syntax for now.

codecov[bot] commented 2 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 25.31%. Comparing base (1763f92) to head (6594052). Report is 2 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #5334 +/- ## ========================================== + Coverage 25.28% 25.31% +0.02% ========================================== Files 444 444 Lines 47574 47601 +27 ========================================== + Hits 12028 12049 +21 - Misses 34603 34609 +6 Partials 943 943 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ffjlabo commented 2 days ago

@khanhtc1202 Updated at 6594052 🙏