Closed khanhtc1202 closed 1 day ago
Attention: Patch coverage is 0%
with 48 lines
in your changes missing coverage. Please review.
Project coverage is 25.28%. Comparing base (
519d3fc
) to head (cb668cf
). Report is 1 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
What this PR does:
Introduce plugin logpsersister package
Why we need it:
In pipedv0, we use logPersister as the writer for stage logs (which will later be used to show stage logs on UI). In this PR, I created
pkg/plugin/logpersister
package, with the same responsibility, but instead of sending the stage log directly to the controlplane, it sends to piped plugin-api then piped will send it to the controlplane.Which issue(s) this PR fixes:
Part of #4980
Does this PR introduce a user-facing change?: