search

pipe01 / legendary-rune-maker

An automation app for League of Legends
Mozilla Public License 2.0
84 stars 10 forks source link

Fix opgg provider #33

Open rincew1nd opened 5 years ago

rincew1nd commented 5 years ago

Fetching of item builds from op.gg. Haven't tested it in-game, but should work properly.

pipe01 commented 3 years ago

Yeah it's just preference, I usually write all my code using vars for all types except primitives

Chobocharles commented 3 years ago

Ah, okie dokes, thank you :)

rincew1nd commented 3 years ago

Yeah. like @pipe01 said, it's just a coding style that i'm using (for work and hobby projects). I'm explicitly defining types when boxing could fail or compiler could not automatically resolve a type.

Also i believe that this PR is outdated as hell, cause markdown could be changed many times for past 2 years.