search

pipedrive / client-nodejs

Pipedrive API client for NodeJS
MIT License
205 stars 82 forks source link

Make UserAgent configurable #66

Closed pcothenet closed 4 years ago

pcothenet commented 6 years ago

Currently, UserAgent defaults to a os + version + has value:

Would it be possible to let the user overwrite this value in the options object?

(We at MadKudu have a Pipedrive integration and your internal team has asked us if we could modify the User-Agent header so calls coming from MadKudu are easily identifiable)

eerootsus commented 4 years ago

Closing this issue as the related PR was closed early in the year. Very likely this issue is no longer relevant to the reporter.

gregarican commented 4 years ago

Speaking of UserAgent values, what value is sent from PipeDrive when it syncs with Office 365? I administer our company's tenant org and see risky sign-in alerts for O365 account access. The IP's are all Amazon EC2 instances, so I'm in the dark there. The UserAgent value comes back as "python-EAS-Client 1.0." Is that what PipeDrive uses on their end?

eerootsus commented 4 years ago

@gregarican O365 sync with Pipedrive is actually performed by Nylas and indeed they are using python-EAS-Client 1.0 as their user agent. https://docs.nylas.com/docs/suggested-office-365-settings

But this question is in no way related to this NodeJS library, so if you have any further issues, please contact our support or try our dev community https://devcommunity.pipedrive.com/