search

pipedrive / client-php

Pipedrive API client for PHP
MIT License
49 stars 57 forks source link

Return types of API responses are void #4

Closed alexandersch closed 2 years ago

alexandersch commented 4 years ago

A lot of times the return type of API calls are void when they are returning an array of data. Could you please update them to a correct value?

E.g.: @return void response from the API call To: @return mixed response from the API call Or: @return array response from the API call

Thanks in advance.

Tlapi commented 4 years ago

This really needs updating.

mschop commented 4 years ago

This issue is open now for about three months. When can we expect this to be fixed? This is really bad because all code quality tools warn about this.

I find it worth considering, that the official client seems to have a lower quality than the community library.

DenisButCheR commented 4 years ago

Hello @alexandersch . Thanks for your report. I can confirm that this is a problem and we will fix it in the future versions of the library. It is in our backlog.

andrii-pukhalevych commented 3 years ago

1 year to update doc block seems to be too much ;)

karol-bialkowski commented 3 years ago

+1 When this fix will be resolved? :)

estevanjantsk commented 2 years ago

Closing this issue since we fixed on https://github.com/pipedrive/client-php/issues/59