Initialize unused recording buffer space to 0xFF.

pipelka / vdr-plugin-xvdr

DISCONTINUED - XVDR Plugin for VDR

GNU General Public License v2.0

43 stars 22 forks source link

Initialize unused recording buffer space to 0xFF. #73

Closed axmhari closed 11 years ago

axmhari commented 11 years ago

Packets generated in cXVDRClient::processRecStream_GetBlock() always have the requested length, even if there is not enough data left for reading in the file. The additional space is not initialized. With this I sometimes had the problem, that a correct TS frame was found in this space, leading to wrong durations and seeking problems. I avoided this by setting those unused bytes to 0xFF.

pipelka commented 11 years ago

Oh. Boy. Thank you. You gave me the hint for a bug I've been hunting.

The bad news: I won't pull your PR.

Please check if the latest version fixes your problem: pipelka/vdr-plugin-xvdr@45a7a22

Again, thanks, and sorry ;-)

axmhari commented 11 years ago

Yes, it fixes the problem and it is definitely the better solution. So never mind and thanks for fixing it!