cannam
commented
7 years ago There is now a PianoRollLayer in wavesUI.helpers. Its implementation may change (at the moment it converts note structures to something understood by the segment shape), but we can start using it all the same.
The next two problems:
- We don't have any logic to identify notes in the returned features yet. Sonic Visualiser does this through RDF URI and/or looking for units with Hz or MIDI in them. This is where we start thinking again about attaching some classification metadata (e.g. RDF feature type URI) to the returned features, and possibly go down the path again of thinking about plugins that can construct higher-level shapes (with descriptive metadata) natively.
- The pianoroll layer expects pitch values in MIDI range (0-127, though they don't have to be integers). Some (most?) note feature extractors produce Hz instead, so we would need to convert those:
57.0 + (12.0 * log(hz / (concertA / 2.0)) / log(2.0))where concertA is in Hz, e.g. 440. Introducing the notion of concert pitch into the UI is a whole other can of worms.
I would also like to make the pianoroll accept a colour mapper like that used for the matrix shape. Later.
LucasThompson
We don't have a working representation for note-type outputs.