search

pipermerriam / flex

Swagger schema validator
MIT License
150 stars 76 forks source link

requirements: allow click 7 #207

Closed blueyed closed 5 years ago

blueyed commented 6 years ago

Not tested really, but allows to pip-tools and flex to use the latest/same click.

javabrett commented 5 years ago

Right, click version 7 is recently released, leading to e.g.:

Collecting click>=5.1 (from Flask>=0.10->-r requirements.txt (line 2))
  Downloading https://files.pythonhosted.org/packages/fa/37/45185cb5abbc30d7257104c434fe0b07e5a195a6847506c074527aa599ec/Click-7.0-py2.py3-none-any.whl (81kB)
...
flex 6.13.2 has requirement click<7,>=3.3, but you'll have click 7.0 which is incompatible.

Are there known incompatibilities with later versions of any of the other required dependencies? Just wondering whether all those upper-bounds could/should be removed?

7a5d79e6d3a4c56454faebc9c2d46f569bb772e9 removes locked versions from requirements.txt. Could probably use a freeze-d version of this file for repeatable builds.

guglielmo commented 5 years ago

Is this going to be merged anytime soon?

blag commented 5 years ago

Thank you for putting in the effort to open this PR.

This PR was superceded by #211 and #213 - there are now no maximum dependency version constraints. Hopefully this lowers the maintenance burden of this project.

I will be releasing a version to PyPI soon.