search

pipes-digital / pipes

Repository for Pipes
https://pipes.digital
GNU Affero General Public License v3.0
261 stars 21 forks source link

Media enclosures not attached to output feed #17

Closed anewuser closed 6 years ago

anewuser commented 7 years ago

https://www.pipes.digital/feed/REOmjQqL has no media enclosures, despite being formed just by:

Feed block (URL: [redacted]) -> Filter block (String: /breakfast/i) -> Out

Both blocks still show the mp3 files in their preview.

onli commented 7 years ago

Yes. We normalize the feeds when being given to a block, and this normalization strips the media enclosure. It would be good to keep it in there, at least as silent payload.

anewuser commented 7 years ago

I see. This really is needed for podcast feeds, so that we don't have to manually open the original URL to download every new episode.

onli commented 7 years ago

Short update: I sent a PR to the normalization gem pipes uses that makes the enclosure accessible. I'll give upstream some time to merge this to avoid having to fork, but one way or another enclosure support will come.

onli commented 6 years ago

Media enclosure support is now live, and it works in https://www.pipes.digital/feed/REOmjQqL for me.

I'm sorry that it took so long.

anewuser commented 6 years ago

Thank you!