search

pipes-digital / pipes

Repository for Pipes
https://pipes.digital
GNU Affero General Public License v3.0
261 stars 21 forks source link

"Internal Server Error" when invalid URL is entered in feed block #19

Closed anewuser closed 6 years ago

anewuser commented 7 years ago

Create a feed block with the URL https://www.pipes.digital/, connect it to Out, and try to save and view your pipe.

A more specific error message should be displayed on the main interface instead of generating a blank screen with the vague "Internal Server Error".

anewuser commented 7 years ago

I'm getting the same error with this (two Youtube feed blocks connected to a combine block): https://www.pipes.digital/feed/DpOrjQOw

What's wrong with it?

onli commented 7 years ago

The combine block had a bug where it died when one of the input pipes had no description. This is fixed now.

For your initial concern I added HTML5 form validation, but I observed since then that this does not trigger yet properly if the input box was never focused. I still hope to trigger that validation with some javascript on save.

onli commented 6 years ago

I had a new try on this, and I think I eliminated the 500ers we realistically can prevent:

  1. When blocks like the filter block are given no input, they will just let their input through
  2. When the feedblock fails to download a feed (because the url is invalid, or that there is no feed on the linked page) it will output a minimal rss reef explaining the problem in the description

Thanks for reporting this, this helps a lot making pipes better.