search

pipes-digital / pipes

Repository for Pipes
https://pipes.digital
GNU Affero General Public License v3.0
261 stars 21 forks source link

Extracting plain dates from downloaded source #32

Closed anewuser closed 6 years ago

anewuser commented 6 years ago

https://www.pipes.digital/editor/aMOQA3Oe

This page has dates in the American format (9/21/2017, 9/16/2017 etc.), but the "Build Feed" block can't currently parse them. Have you considered adding this feature? Users would have to be able to tell if strings are in the international or American format, though.

onli commented 6 years ago

Hi. No, I did not have this on my radar.

I found https://github.com/jeremyevans/ruby-american_date, which in my short test seems like it would properly extend the ruby date parser to understand this date format. I will test it out with the whole pipes platform and see whether this is a solution.

onli commented 6 years ago

This should work now. Could you confirm?

anewuser commented 6 years ago

The dates are off by one day (one day earlier on Pipes):

https://www.pipes.digital/feed/aMOQA3Oe https://krita.org/en/?post_type=post&s=

I mentioned the need for a toggle because dates like 05/02/2017 can be interpreted in different ways: May 2 in the US and February 5 in other countries.

onli commented 6 years ago

The dates are correct at my side. We are probably in a different time zone, and maybe the Krita site does some voodoo to adjust the dates depending on the timezone of our browser? Krita 4.0 Beta 1 was released on 1/12/2018, according to the site, and the pipes feed shows January 11, 2018 to me.

I mentioned the need for a toggle because dates like 05/02/2017 can be interpreted in different ways: May 2 in the US and February 5 in other countries.

Right, I forgot about the complexity of that area. But this would need its own date interpretation block, and a very capable gem (I doubt I could get this right if I tried to solve this on my own). I'm not sure how to handle that.

anewuser commented 6 years ago

Yes, there's some mix-up with time zones, because the Krita site says 1/11/2018 to me, and the generated feed source code has 10 Jan 2018 23:00:00 -0000 on Firefox.

Anyway, this isn't too important since even without dates all future posts would arrive accordingly to one's feed reader. Thank you for adding the possibility to parse the Krita page.