pipes-digital / pipes

Repository for Pipes
https://pipes.digital
GNU Affero General Public License v3.0
261 stars 21 forks source link

Titles of feeds built from scratch #33

Closed anewuser closed 6 years ago

anewuser commented 6 years ago

Pipes that don't extract existing feeds and build a new feed from scratch could use the titles we manually entered for them instead of showing "Feed created by Pipes".

Example: https://www.pipes.digital/feed/aMOQA3Oe could have "Krita" as its title.

If you use "Feed created by Pipes" for promotion, I think it'd be better to add it to the body of feed posts instead of the title to make it easier to manage multiple feeds in a reader.

onli commented 6 years ago

Hi

If you use "Feed created by Pipes" for promotion

No, I just needed a text for the title, because otherwise the feed builder breaks.

I can let pipes automatically use the title of the pipe for the feed. But maybe it would be better to have a text input in the feed builder block instead? Or combined: Use the pipes name as feed title if no name is supplied?

anewuser commented 6 years ago

I'd be fine with either, but the combined option sounds good to cover users who, for some reason, want different names for pipes and their corresponding feeds.

onli commented 6 years ago

I pushed this to the server. Does it work as you would expect?

anewuser commented 6 years ago

Yes, the name changed to "Krita". Thanks!

anewuser commented 6 years ago

@onli Can you make the title input accept connections from other blocks? That'd be useful for dynamic pipes like https://www.pipes.digital/pipe/k0OolxqK and https://www.pipes.digital/pipe/j1O4Ve9d.

onli commented 6 years ago

You mean the title input of the Build Feed block, and to have it be connected to the output of an extract or a replace block?

anewuser commented 6 years ago

Yes, so that each generated feed will have a custom title.

onli commented 6 years ago

The difficulty here is that so far, the title input of the feed builder block is a text input. It can only be connected to text input blocks, not to regular blocks, because those carry a different payload (RSS-feeds always, instead of plain strings). I have no good scheme in my mind (yet?) on how to enable that. Maybe we need something like a String Builder block, a block to generate strings from other blocks, but how would that one work exactly?

anewuser commented 6 years ago

Since that would require some complicated changes, I'm going to just use the already existing text input option and manually enter titles. You can direct other users to do the same and focus on other things. :)

I'm being affected by that problem again, though. Every time I connect the text input block to the build feed block, pressing save doesn't save it - https://www.pipes.digital/pipe/k0OolxqK . I've tried it both on Firefox and Opera.

onli commented 6 years ago

Could you please try again? This should be a mostly unrelated bug in the js code called when connecting pipes, the wrong order in an array. In that case this would be fixed now.

anewuser commented 6 years ago

Thanks!