pipes-digital / pipes

Repository for Pipes
https://pipes.digital
GNU Affero General Public License v3.0
254 stars 21 forks source link

Feed viewer #46

Closed anewuser closed 5 years ago

anewuser commented 5 years ago

Firefox has removed the built-in feed viewer, and now it's become harder to quickly verify changes to your pipes, since external services and readers may cache them. Would it be possible for you to add a formatted viewer like this to Pipes, so that we don't have to install an extra extension just for this?

live-bookmarks

onli commented 5 years ago

Happy new year! I was never certain Firefox will really also remove the RSS viewer function and not just the Live bookmarks. It's a shame.

Yes, I think I can introduce an intermediate page that displays the feeds and has an option at the top to download the original file. Might even be the same mechanism that will allow to improve the block inspector.

anewuser commented 5 years ago

Yes, I feel the same way about their recent feature removals.

Happy new year. I wasn't sure if you were on vacations from Github. 😄

onli commented 5 years ago

I indeed just came back from a vacation, but always had an eye on this repo :)

https://www.pipes.digital/feedpreview/VNzYZg94 is the current implementation, it is accessible by clicking on the feed button on https://www.pipes.digital/pipe/VNzYZg94, the pipe page. Also the "Pipe Output" link in the editor will now point to such an intermediary page.

Does this work for you?

anewuser commented 5 years ago

Thanks. Make sure to add a <link rel="alternate" type="application/rss+xml" href="http://example.com/feed" /> tag (or doing this), so that copying the preview link to readers will also work.

onli commented 5 years ago

Great idea, it's added.

anewuser commented 5 years ago

@onli Try to generate a feed with this pipe: https://www.pipes.digital/pipe/k0OolxqK

Firefox 64 attempts to download the file.

onli commented 5 years ago

The feed button leads to https://www.pipes.digital/feedpreview/k0OolxqK, that opens a download prompt for you?

anewuser commented 5 years ago

The feed button works and shows the SoundCloud profile I've set as the default one. I'm talking about the form to generate a feed for another profile.

onli commented 5 years ago

Ah! Okay, that I can confirm. That still points to the raw feed, not the preview - and right, should be changed.

onli commented 5 years ago

That was almost completely in place already. I added the missing pieces and pushed it online. The form will now lead to the feedpreview, and also the raw feed link there gets the new params to not point to the default raw feed.

anewuser commented 5 years ago

@onli can you add the parameters to the link tag, so that it works on feed readers too? If I paste this into Inoreader -

https://www.pipes.digital/feedpreview/k0OolxqK?Tracks+URL=https%3A%2F%2Fsoundcloud.com%2Fglobalriddims&Title=Global+Riddims

it gets only:

<link rel="alternate" type="application/rss+xml" href="https://pipes.digital/feed/k0OolxqK" />

onli commented 5 years ago

Right! Thanks, that's missing the params.

onli commented 5 years ago

The href contains not the parameters exactly like the button to the raw feed. Does it work in your feed reader?

anewuser commented 5 years ago

Yes, it seems to be working. Thanks!