pipipipi2002 / pe

0 stars 0 forks source link

Missing Access Rights on Storage object class diagram #13

Open pipipipi2002 opened 1 year ago

pipipipi2002 commented 1 year ago

No information of access rights (private, public, protected)

Screen Shot 2022-11-11 at 20.42.38.png

nus-se-bot commented 1 year ago

Team's Response

I did not initialize any access modifier to those attributes since by default, it means that those attributes can only be accessed inside the class or classes in the same package. For this case, the package only has Storage class, so it will not cause any issue for the program.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Medium]

Reason for disagreement: It is a syntax error as laid out by the CS2113 UML design standard. This bug should at least be a severity medium bug, as it hinders the developer's ability to scan for information and access rights are pretty important. Moreover, since the attributes are in all caps, it should be in italics. Moreover, the team mentioed that the attributes can only be accessed inside, but I am only aware of that only after the team mentioned it, thus it is definitely a big issue and the bug is an issue with at least a severity medium.